Handle WebAuthn challenge having multiple factors #6945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotttrinh
changed the title
|
I would kind of prefer if we also looked at the old link, but I guess it's not totally critical for something like this |
jaclarke
approved these changes
Mar 1, 2024
|
Oh yeah, I remember we talked about that. Lemme see if it's easy to distinct union them together in the query so that everything else just keeps working. |
We made some big changes late in the game for allowing multiple WebAuthn factors for a given (email, user_handle) pair, but didn't update this in the authentication challenge flow. Since we cannot remove the old link, this adds an additional link and ignores the old one.
scotttrinh
force-pushed
the
webauthn-auth-challenge-multi-factor
branch
from
f83cb55 to
2af19e9
Compare
|
Let me know if that makes sense! |
|
As discussed, just removing the property. |
jaclarke
reviewed
Mar 1, 2024
Co-authored-by: James Clarke <[email protected]>
msullivan
pushed a commit
that referenced
this pull request
Mar 7, 2024
msullivan
pushed a commit
that referenced
this pull request
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We made some big changes late in the game for allowing multiple WebAuthn factors for a given (email, user_handle) pair, but didn't update this in the authentication challenge flow.
Since we cannot remove the old link, this adds an additional link and ignores the old one.